feat: allow injecting into all extensions#592
Open
waruhachi wants to merge 4 commits intoclaration:mainfrom
Open
feat: allow injecting into all extensions#592waruhachi wants to merge 4 commits intoclaration:mainfrom
waruhachi wants to merge 4 commits intoclaration:mainfrom
Conversation
2 tasks
claration
requested changes
Feb 27, 2026
Comment on lines
+293
to
+297
| guard let extensionBundle = Bundle(url: extensionURL), | ||
| let extensionExecutable = extensionBundle.executableURL else { | ||
| Logger.misc.warning("Skipping \(extensionURL.lastPathComponent): couldn't read bundle") | ||
| return | ||
| } |
Owner
There was a problem hiding this comment.
Suggested change
| guard let extensionBundle = Bundle(url: extensionURL), | |
| let extensionExecutable = extensionBundle.executableURL else { | |
| Logger.misc.warning("Skipping \(extensionURL.lastPathComponent): couldn't read bundle") | |
| return | |
| } | |
| guard | |
| let extensionBundle = Bundle(url: extensionURL), | |
| let extensionExecutable = extensionBundle.executableURL | |
| else { | |
| Logger.misc.warning("Skipping \(extensionURL.lastPathComponent): couldn't read bundle") | |
| return | |
| } |
Comment on lines
+100
to
+102
| if !_injectedDylibNames.isEmpty { | ||
| _injectIntoAllExtensions(dylibNames: _injectedDylibNames) | ||
| } |
Owner
There was a problem hiding this comment.
Suggested change
| if !_injectedDylibNames.isEmpty { | |
| _injectIntoAllExtensions(dylibNames: _injectedDylibNames) | |
| } | |
| if _options.injectIntoExtensions && !_injectedDylibNames.isEmpty { | |
| _injectIntoAllExtensions(dylibNames: _injectedDylibNames) | |
| } |
|
|
||
| // Injects all dylibs into all discovered extensions | ||
| private func _injectIntoAllExtensions(dylibNames: [String]) { | ||
| guard _options.injectIntoExtensions else { return } |
Owner
There was a problem hiding this comment.
Suggested change
| guard _options.injectIntoExtensions else { return } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for injecting tweaks into all app extensions, including plugins and extensions, in addition to the main app bundle as mentioned in #584.
A toggle button is added in the Tweak section of the Modify settings. This setting is not persistent and is disabled by default.